-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL2_mixer: adopt and refactor #308362
SDL2_mixer: adopt and refactor #308362
Conversation
Result of 5 packages marked as broken and skipped:
1 package blacklisted:
27 packages failed to build:
242 packages built:
all failures seemed to be failing on hydra, but i'd like to run this anew now that my pygame fixes are merged. Diff LGTM, but merge conflict |
- finalAttrs - use fetchFromGitHub (since the url is deactivated) - strictDeps - no nested with
- get rid of rec - use fetchFromGitHub (since the url is deactivated)
Result of 5 packages marked as broken and skipped:
1 package blacklisted:
13 packages failed to build:
261 packages built:
errors are either due to requireFile, or exist on hydra one error of interest, from manaplus:
but that error already exists on hydra: https://hydra.nixos.org/build/256700787 LGTM |
Description of changes
Following #307078
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.